search

dimagi / django-cte

Common Table Expressions (CTE) for Django
Other
334 stars 46 forks source link

Pin Django to supported versions #53

Closed lithammer closed 2 years ago

lithammer commented 2 years ago

In a similar vain as #52. This ensures that django-cte can't be installed together with an unsupported/incompatible version of Django (e.g. Pip will complain during installation).

We had an "issue" with dependabot kept trying to upgrade Django to v4.0.x in one of our projects because it couldn't figure out that django-cte v1.1.5 and Django v4.0.x wasn't compatible. I think this would solve such a scenario.

A downside is increased maintenance burden in that a new release will have to made for every major/minor release of Django to update the supported version range.

Feel free to close if you think this will just be a maintenance headache.

millerdev commented 2 years ago

I'd rather not do this since we don't yet know if Django 4.1 will break compatibility with django-cte. I'd rather keep it open and let downstream projects moderate allowed versions with their own requirements files after doing whatever testing is adequate for their usage. Likewise, I don't know that we've broken compatibility with versions of Django prior to 2.2 (we just do not test against them anymore). Finally, I'd like to avoid extra maintenance if possible since the time I can spend on this project is limited.

lithammer commented 2 years ago

Fair enough!