search

dimsemenov / Magnific-Popup

Light and responsive lightbox script with focus on performance.
http://dimsemenov.com/plugins/magnific-popup/
MIT License
11.39k stars 3.48k forks source link

Close button 1px shift while on click active. #983

Closed bs-thomas closed 7 years ago

bs-thomas commented 7 years ago

Hello there,

When I click on the close button, it shifts the button down by 1px. I noticed that this happens due to the CSS applied on .mfp-close declaration inside magnific-popup.css, when position:absolute; top:0; right:0; is applied.

When you remove top and right attributes, this issue becomes more obvious (shifts more than 1 px).

I noticed all the demos on the website have this behavior as well.

I was wondering if this behavior is intentional, and if it is possible to remove it.

Thank you very much for your kind assistance in advance.

dimsemenov commented 7 years ago

Yes, it's intentional. To indicate activate state. Can be removed via CSS https://github.com/dimsemenov/Magnific-Popup/blob/master/src/css/main.scss#L251

bs-thomas commented 7 years ago

Ah I see, thank you very much for the quick response. Understood, and will close the issue.