search

diogotr7 / OpenRGB.NET

C# client for the OpenRGB SDK
MIT License
40 stars 16 forks source link

Async/Await Support? #27

Open Tederean opened 1 year ago

Tederean commented 1 year ago

Do you plan to add asynchronous functions to the library? This makes sense for network IO.

If it's not planned, would you accept a pull request provided it was of reasonable quality?

diogotr7 commented 1 year ago

Hi,

I haven't added any async support because neither Artemis nor Aurora (which is why i wrote this library in the first place) would use it. I don't have anything against this in principle. How would you expect such an API to look like? Send and SendAsync versions of the same thing, in the same class? Maybe a constructor parameter to set async mode on the socket? I don't mind writing this myself as some of the code directly related to async reading could use some cleanup, just unsure how to design this API.