search

diptangsu / Data-Structures

This contains all the programs for data structures that are a part of the syllabus of MAKAUT 2nd year Computer Science and engineering course.
17 stars 33 forks source link

Create Binary Tree.py #27

Closed harry-stark closed 5 years ago

pep8speaks commented 5 years ago

Hello @Harrystark99! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

[Line 1:1](https://github.com/diptangsu/Data-Structures/blob/cb308512233ba9d71611c011a98e803131aad51d/src-python/Binary Tree.py#L1): W293 blank line contains whitespace [Line 95:25](https://github.com/diptangsu/Data-Structures/blob/cb308512233ba9d71611c011a98e803131aad51d/src-python/Binary Tree.py#L95): W291 trailing whitespace [Line 125:51](https://github.com/diptangsu/Data-Structures/blob/cb308512233ba9d71611c011a98e803131aad51d/src-python/Binary Tree.py#L125): W291 trailing whitespace [Line 129:55](https://github.com/diptangsu/Data-Structures/blob/cb308512233ba9d71611c011a98e803131aad51d/src-python/Binary Tree.py#L129): W291 trailing whitespace [Line 148:80](https://github.com/diptangsu/Data-Structures/blob/cb308512233ba9d71611c011a98e803131aad51d/src-python/Binary Tree.py#L148): E501 line too long (96 > 79 characters) [Line 149:80](https://github.com/diptangsu/Data-Structures/blob/cb308512233ba9d71611c011a98e803131aad51d/src-python/Binary Tree.py#L149): E501 line too long (95 > 79 characters) [Line 152:80](https://github.com/diptangsu/Data-Structures/blob/cb308512233ba9d71611c011a98e803131aad51d/src-python/Binary Tree.py#L152): E501 line too long (88 > 79 characters) [Line 201:80](https://github.com/diptangsu/Data-Structures/blob/cb308512233ba9d71611c011a98e803131aad51d/src-python/Binary Tree.py#L201): E501 line too long (88 > 79 characters) [Line 206:80](https://github.com/diptangsu/Data-Structures/blob/cb308512233ba9d71611c011a98e803131aad51d/src-python/Binary Tree.py#L206): E501 line too long (86 > 79 characters) [Line 234:80](https://github.com/diptangsu/Data-Structures/blob/cb308512233ba9d71611c011a98e803131aad51d/src-python/Binary Tree.py#L234): E501 line too long (88 > 79 characters) [Line 277:5](https://github.com/diptangsu/Data-Structures/blob/cb308512233ba9d71611c011a98e803131aad51d/src-python/Binary Tree.py#L277): E741 ambiguous variable name 'l'

diptangsu commented 5 years ago

In python, we don't use getters and setters. If you can please remove all getters and setters and refactor your code accordingly and also follow pep8 guidelines, i'll merge your PR.