Fix bug in dce_vasprintf

direct-code-execution / ns-3-dce

Run real programs in the discrete time simulator ns3

http://www.nsnam.org/projects/direct-code-execution/

76 stars 46 forks source link

Fix bug in dce_vasprintf #132

Closed fvel closed 1 year ago

fvel commented 3 years ago

Hello, I'm woriking on porting FRRouting to dce. I've fixed a couple of bugs while working on it and I'd like to merge them.

The function dce_vasprintf calls to the system vasprintf, using a ret variable to ask for memory and copy the string that is returned by vasprintf. ret is the amount of bytes in the string without considering the termination character \0. For that reason there is a bug here and ret should be ret+1.

tomhenderson commented 2 years ago

Hello @fvel, is there a commit author string that we should use, rather than the below that is presently displayed?

fvel <58647413+fvel@users.noreply.github.com>

fvel commented 2 years ago

If you could use "Felipe Velazquez Serra fvelazquez@fing.edu.uy" it would be great.

tomhenderson commented 1 year ago

pushed in commit 2d7edf8