direnv / direnv-archlinux

Mirror of the Arch Linux package for direnv
https://aur.archlinux.org/packages/direnv/
3 stars 7 forks source link

Allow all architectures #11

Closed FloopCZ closed 5 years ago

FloopCZ commented 5 years ago

Hi, thank you for this project! It seems to work quite well on other architectures as well (e.g., ARM), I suggest not to limit the architectures explicitly.

zimbatm commented 5 years ago

sounds good, thanks!

PanisSupraOmnia commented 5 years ago

Hi, just popping in to say that while it's great that direnv works on many platforms, because the build produces ELF files, it should not specify the arch as any. Users of platforms other than those specified can modify the PKGBUILD or use makepkg -A, and if it works properly, then the addition can be PRed here. It's a little more work, but arch=('any') is for platform-independent packages such as scripts, fonts, and themes, not binaries.

Reference for this is the (abbreviated) output of namcap: direnv E: ELF file ('usr/bin/direnv') found in an 'any' package.

FloopCZ commented 5 years ago

Hi @PanisSupraOmnia, you are right, it is probably not a good solution for compiled go. I made a new PR: #12 .