search

dirtyjtag / DirtyJTAG

JTAG probe firmware
MIT License
464 stars 70 forks source link

Improve Docker build support #97

Closed jeanthom closed 1 year ago

jeanthom commented 2 years ago

Fixes #96

zoobab commented 2 years ago

I will try it out asap, but it looks ok to me.

zoobab commented 2 years ago

It does not build for me, you have to add:

RUN git submodule init RUN git submodule sync RUN git submodule update

to get the unicore-mx library.

jeanthom commented 2 years ago

Is it a good deployment practice for Docker to perform Git commands inside a Docker container? I wasn't doing it in the first place because submodule cloning is supposed to be performed by docker build.

zoobab commented 2 years ago

I have not tried this actually:

$ docker build https://github.com/jeanthom/DirtyJTAG.git --output type=tar,dest=dirtyjtag.tar

I cloned the repo and did a 'docker build .'

Will try the first method later on...