search

dis-co / disco

Distributed Show Control
GNU General Public License v3.0
9 stars 6 forks source link

copy paste io-box id handling #55

Open ingolfheinsch opened 6 years ago

ingolfheinsch commented 6 years ago

Description

if i copy and paste an exposed io box in vvvv it will be pasted with the same id as the source - so it wont appear in front end. even re-exposing using ctrl + k twice doesnt generate a new id.

HowTo Reproduce

copy and paste exposed io-box

Expected and actual results

pasted io-boxes should get a new unique id

Environment information

Related information

ehenze commented 6 years ago

But didn’t we say we want it like that? We want to be able to use the same exposed IOBox twice. - In Context though.. Un- and Re-Exposing should make it appear as a new one though.

Am 04.01.2018 um 12:16 schrieb ingolfheinsch notifications@github.com:

Description

if i copy and paste an exposed io box in vvvv it will be pasted with the same id as the source - so it wont appear in front end. even re-exposing using ctrl + k twice doesnt generate a new id.

HowTo Reproduce

copy and paste exposed io-box

Expected and actual results

pasted io-boxes should get a new unique id

Environment information

Disco Version: 1.0.1 Member Count: 1 Type of Client: vvvv Related information

RunTime Version: Operating system: — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dis-co/disco/issues/55, or mute the thread https://github.com/notifications/unsubscribe-auth/AA5nbohWMzDLpgIg2FlfgBjc2wmm8ctCks5tHLL5gaJpZM4RS30l.

ingolfheinsch commented 6 years ago

how it could work: when receiving the "new node added" event the graph api could cache the new node then check if there is aleready a existing node with the same id in the local graph and if so generate a new one for the cached node. the behavior for cut & paste - where the id is copied - remains untouched.

ingolfheinsch commented 6 years ago

if wanted. removing id by de-expose event could be a solution

ingolfheinsch commented 6 years ago

but at the moment the copy and paste acts like this: after pasting i got 2 io boxes with the same id but only the source one is sending and receiving graph events.