search

disco-lang / disco

Functional teaching language for use in a discrete mathematics course
Other
164 stars 23 forks source link

Drop dependency on `polysemy-zoo` #380

Closed LeitMoth closed 6 months ago

LeitMoth commented 6 months ago

Copied over ConstraintAbsorber, MonadCatch, and Random from polysemy-zoo, so that we can remove it as a dependency. Included the polysemy-zoo license. Removed Disco's Random.hs file, which only re-exported polysemy-zoo's Random Updated the needed imports.

LeitMoth commented 6 months ago

I don't think putting the issue number in the name of the pull request properly referenced it. This should resolve #375.

LeitMoth commented 6 months ago

It also seems that the exact same thing was already done on the ghc-9.8 branch: f72a7dbbd418e89593e674009ea17c1c79af6bfe So this work may have been redundant.

byorgey commented 6 months ago

It also seems that the exact same thing was already done on the ghc-9.8 branch:

Hah, oops, I had totally forgotten about that. That's why I was getting deja vu during our meeting this morning. That's OK, we can merge this and I will update the ghc-9.8 branch. And the work was not redundant in the sense that you still learned some things by doing it.

byorgey commented 6 months ago

@LeitMoth Note you'll need to click on Details next to the failed restyled check below and follow the instructions for applying the restyling, then push the new commit. The code copied into our repository needs to conform to our style guidelines.