search

discourse / mini_mime

minimal mime type library
MIT License
95 stars 34 forks source link

Bump to version 1.0.0 #9

Closed radar closed 6 years ago

radar commented 6 years ago

This gem is depended on by the mail gem, which is depended on by actionmailer, which is depended on rails. This means that every single Rails installation will install this gem, and that means that this gem will be used in production environments.

semver.org explains that versions < 1.x...

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

I think that because this gem is now being used in production environments, it would be sensible to consider that the API here is stable and reliable.

Leaving this version at 0.1.4 would indicate that the API could change, which may cause issues for mail, due to its relaxed version dependency (currently, >= 0.1.1). Changing the API for mini_mime will require API changes to mail too.

It's for this reason that we should indicate that mini_mime's API is stable with a 1.0.0 version number.

SamSaffron commented 6 years ago

sure, seems fine to me, this is very stable.

SamSaffron commented 6 years ago

can you also add CHANGELOG here ?

radar commented 6 years ago

Updated CHANGELOG with 1.0.0.

SamSaffron commented 6 years ago

thanks! a new gem is released!