search

discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics
MIT License
532 stars 154 forks source link

Allow gem to be used with ruby 2.5.5 #220

Closed TLischkaRemerge closed 2 years ago

TLischkaRemerge commented 2 years ago

Since it is not possible to update ruby on the api servers at the current time, prometheus_exporter needs to continue working with the installed version (2.5.5) This change means that we can use the recently added features without upgrading ruby

SamSaffron commented 2 years ago

Sorry I can not accept this, Ruby 2.5 was end of life 10 months ago. We have a strong policy of not supporting end of life Ruby which may have critical, unpatched, security vulnerabilities

TLischkaRemerge commented 2 years ago

Oops, apologies for the noise here. I thought I'd made this one against our own fork as a messy and temporary solution but I mistakenly chose the upstream repo

SamSaffron commented 2 years ago

No worries at all @TLischkaRemerge! good luck updating Ruby! 2.7 is better in almost all metrics than 2.5. 3.1 is also a very good release.