discourse / prometheus_exporter

A framework for collecting and aggregating prometheus metrics
MIT License
525 stars 153 forks source link

Order histogram buckets in increasing numerical order #233

Closed clupprich closed 2 years ago

clupprich commented 2 years ago

The docs on the Prometheus exposition format say

The buckets of a histogram and the quantiles of a summary must appear in increasing numerical order of their label values (for the le or the quantile label, respectively).

This hasn't been a problem with the Prometheus versions we've used up to now. However, I have a client that's migrating to GCP right now where they're using the Managed Prometheus offering, which doesn't process the wrongly ordered histogram buckets.

Not sure what (custom?) Prometheus version GCP is using here (it's all pretty much hidden), though.

SamSaffron commented 2 years ago

Nice change!