search

disk91 / stm32-it-sdk

Disk91 STM32 IoT SDK
https://www.disk91.com
GNU General Public License v3.0
45 stars 19 forks source link

Fix uart changebaudrate function #71

Closed zokl closed 3 years ago

zokl commented 4 years ago

A repeat of previous pull request with additional support for baud rate changing in UART IT mode.

disk91 commented 4 years ago

Hi, I'm not agreeing with this proposal as the practice is not to declare a serial in ITSDK_WITH_UART_RXIRQ if not declared in ITSDK_WITH_UART. So I would prefer to have a verification and error in config.h file to ensure an UART in ITSDK_WITH_UART_RXIRQ is also declared in ITSDK_WITH_UART. Did this makes sense.regarding what you want to achieve with this pull request ? Sincerely, Paul

zokl commented 4 years ago

Hi,

I would like to make baudrate change working in RXIRQ on PULL mode too. Your last commit enables only baudrate change on USART2 in RXIRQ mode.

disk91 commented 4 years ago

Ok, I got it, last commit should fix this