search

disney / meteor-base

Base Docker image for use by Meteor apps
Other
262 stars 119 forks source link

No version needed in `docker-compose.yml` and updates to reflect latest changes in the docker ecosystem #149

Open tippexs opened 1 year ago

tippexs commented 1 year ago

Thanks for the awesome description and work on the Dockerfiles / Docker compose files! Really appreciated it!

As Docker Captain I am always looking at the Docker parts of a project and will try to improve them. Just one very very little thing.

The version in your docker-compose.yml is now optional can be omitted. Furthermore the docker-compose.yml should now be compose.yml.

https://docs.docker.com/compose/compose-file/03-compose-file/

Last but not least the docker-compose up command should now be docker compose up. I am happy to submit a PR if you are open for that. As said JUST very small changes to reflect the latest updates in the Docker ecosystem.

Thanks for the great work! Cheers

GeoffreyBooth commented 1 year ago

Sure, a PR would be appreciated. Thanks!