disney / meteor-base

Base Docker image for use by Meteor apps
Other
262 stars 119 forks source link

update.sh adds duplicated lines to support.sh #155

Closed bladerunner2020 closed 8 months ago

bladerunner2020 commented 8 months ago

When I run ./update.sh --meteor-version 2.15 --node-version 14.21.4 I got multiple lines with 2.15 in support.sh

image

This is because of this line: do_sed $"s|'${node_version}'|'${node_version}'\\n elif [[ \"\$1\" == ${new_meteor_version} ]]; then node_version='${new_node_version}'|" ./support.sh

I think that $ before sed's substitute command is treated as address not as the latest occurrence.

GeoffreyBooth commented 8 months ago

Fixed by #156