search

distributed-system-analysis / pbench

A benchmarking and performance analysis framework
http://distributed-system-analysis.github.io/pbench/
GNU General Public License v3.0
182 stars 109 forks source link

Unit testing & review comments #3608

Closed dbutenhof closed 4 months ago

dbutenhof commented 4 months ago

PBENCH-1315

The index-map fix was submitted without unit tests so we can get it deployed to resolve the immediate PostgreSQL resource problems. This follow-on adds unit testing (and some late review comments).

dbutenhof commented 4 months ago

Ugh:

FileExistsError: [Errno 17] File exists: '/home/jenkins/.pquisby/'

webbnh commented 4 months ago

Ugh:

FileExistsError: [Errno 17] File exists: '/home/jenkins/.pquisby/'

The good news is, that only happens on the first build....

dbutenhof commented 4 months ago

I could maybe throw in a few more mock cases but basically there are three realistically unreachable edge cases left uncovered and making them fire would be messier than I want to try to justify right now. We're at 97% line coverage and 95% conditional coverage, which is pretty good.

dbutenhof commented 4 months ago

Sorry that you're suffering "bored time"...nice to see this finished, though! 😁

More like, I read your comments and my brain got locked into these PRs so the only way past was through ... 😆