search

disusered / cordova-open

Open audio, video, images and more with applications installed on the user's device
MIT License
54 stars 55 forks source link

Added support for recent versions of Android #55

Closed fkirill closed 5 years ago

fkirill commented 7 years ago

Hey guys, could you please review and merge the pull request. Resolved issues while opening image files on recent versions of Android (>=24). Based on http://stackoverflow.com/questions/25592206/how-to-get-your-context-in-your-phonegap-plugin and http://stackoverflow.com/questions/39450748/intent-shows-a-blank-image

fkirill commented 7 years ago

Looks like there is a problem in Travis environment, could not build android version due unsatisfied to Java8 requirements

disusered commented 7 years ago

Looking at it, thanks for the PR!

klodeckl commented 7 years ago

Your branch seems to work, I just had to add compile 'com.android.support:support-v4:+' in the dependencies section of build.gradle (otherwise compile failed). Thanks!

vasuvuggu commented 6 years ago

Hi disusered, could u plz update this source code so that it supports for even android also w.r.t. latest versions 7.0 onwards.

P110 commented 6 years ago

No idea if this was ever working or if it is still an appropriate approach or not anymore, but I'm trying to use it and no matter which way I put in a file path it keeps giving me "Failed to find configured root that contains : {my path without the file:// and usually the first item before a slash}"

Is there anything I'm doing wrong? I'm trying to access a local asset e.g. file://android_asset/www/img/file.pdf file://packageName.provider/www/img/file.pdf file://packageName.provider/assets/www/img/file.pdf

etc

Owlbertz commented 6 years ago

Just pulled this into my project and can confirm this works.

@disusered please think about merging this PR.

disusered commented 5 years ago

Sorry for being so absent, I will review and merge tonight. I am also open to taking on contributors or others who wish to take responsibility for these projects as I have been absent from Cordova for so long. Thank you so much for your support thus far and again apologies for the deficient stewardship, I hope to make amends this coming year!

wedgberto commented 5 years ago

This fixes issue #58 (FileUriExposedException) one day after I refactored my app to use cordova-plugin-file-opener2 for that very reason! I had rebuilt my app after fixing a trivial bug and updated android-targetSdkVersion to 27 (Google Play Store requires at least 26 since November 2018) and found that this exception was occurring on all my device file system access via cordova-open

Owlbertz commented 5 years ago

I am glad to see that this fix was merged into the master branch recently. Will there be an official update to the NPM package any time soon?

disusered commented 5 years ago

I will cut a release Saturday. For now you can use the git url via:

npm install disusered/cordova-open#master --save
FlossyWeb commented 5 years ago

Thanks a lot guys.

@disusered before you update the NPM package, beware that the #master branch has to be merged with the #develop branch first ! Because at the time I'm writing the working git url isn't npm install disusered/cordova-open#master --save but npm install disusered/cordova-open#develop --save

Kind regards.

adrianjarc commented 5 years ago

Is there any ETA when this will make it to release?

disusered commented 5 years ago

Is there any ETA when this will make it to release?

It's published now, apologies.

adrianjarc commented 5 years ago

Thank you.