search

divideconcept / FluidLite

Very light version of FluidSynth designed to be hardware, platform and external dependency independent.
Other
125 stars 34 forks source link

[Suggeston] Replace libvorbis with stb_vorbis #10

Open RyanBram opened 7 years ago

RyanBram commented 7 years ago

One of the goal of FluidLite is to become a lightweight replacement for Fluidsynth. As vorbis format is only needed for sf3 support, using libvorbis+libogg as additional library will make FluidLite become heavier. By replacing libvorbis with stb_vorbis it will get benefits such as:

  1. stb_vorbis is more lightweight than libvorbis;
  2. stb_vorbis has lesser dependencies than libvorbis (it only need itself without libogg);
  3. stb_vorbis is licensed under public domain.

I don't have any programming skills so I am really sorry if I cannot help much other than giving suggestion.

Best regards, RyanBram

Link https://nothings.org/stb_vorbis/ https://github.com/nothings/stb

MrSapps commented 7 years ago

Might make sense to make SF3 support totally optional so vorbis isn't required at all? Then there will be zero deps?

hanetzer commented 7 years ago

I don't know. There is a good chance that a given project who would benefit from fluidsynth->fluidlite is already dealing with audio in various formats, and as such probably already needs libvorbis/libogg.

MrSapps commented 7 years ago

I think so too, which is why having it completely optional would be the nicest option IMO.

katyo commented 4 years ago

I added support for __stb_vorbis__ in my fork. Also #17 is fixed.

katyo commented 4 years ago

Because my PR was merged, can we close this issue?