search

divviup / janus

Experimental implementation of the Distributed Aggregation Protocol (DAP) specification.
Mozilla Public License 2.0
54 stars 15 forks source link

aggregator: fix broken test #3507

Closed inahga closed 6 days ago

inahga commented 6 days ago

A few function arguments were missed.

branlwyd commented 6 days ago

Yep, git didn't flag this at all; and it seems GH doesn't require a PR to compile against the base it is merging against, probably to allow multiple PRs to run CI & merge without inducing serialization?

divergentdave commented 6 days ago

Yeah, though the "merge queue" feature can require checks to succeed on merge commits first.