diyabc / diyabcGUI

User interface to DIYABC/AbcRanger
https://diyabc.github.io/
Other
4 stars 2 forks source link

Problem with the shiny app data validation prior to Simulate #107

Closed jferrerobiol closed 2 years ago

jferrerobiol commented 3 years ago

Hi gdurif,

Firstly, thank you for implementing RF DIYABC. I am on a mac and am therefore using the shiny app, and seem to have run into a bug. I uploaded my SNP file and wrote a simple model. I validated all sections, which seemed to be fine. At the end when I validate, the message says, 'Project is ready for training set simulation'

However, when I run simulate, I get an error message saying ´Project is not ready. Check settings above´ I cannot however see any errors in the validation procedures.

To double-check this wasn't an issue with my SNP data file, I also uploaded the test SNP file, but I get the same error. The simulate section works fine if I upload the example data with its relevant metadata (header.txt etc). So this issue only seems to appear when starting a New Project

Thank you for your time

JFO

jferrerobiol commented 3 years ago

Just a small update. I cannot generate the project header.txt by doing ´Save Project´ or by looking in the R tmp directory (this for both the example SNP dataset and my own)

jferrerobiol commented 3 years ago

The same issue persisted when using the .bat app on a Windows machine. The version I have been using in both cases is v.1.1.0.

Thank you for your time and I apologise for the inconvenience!

gdurif commented 3 years ago

Hi, thanks for the feedback, no worries, I am the one to apologize for the trouble. I will look into it.

If there is no confidentiality issue, could you detail me the setup (historical scenario, priors, etc.) that you tried to use ?

Thanks in advance

jferrerobiol commented 3 years ago

Hi gdurif,

Thanks for your rapid answer. I tried different setups including the ones included in the indseq_SNP example and none has worked for me. I send you screenshots of one I am trying using 2 of the historical scenarios in the indseq_SNP example where you can see the error message I get:

Screenshot 2021-09-14 at 12 16 33 Screenshot 2021-09-14 at 12 16 50 Screenshot 2021-09-14 at 12 17 08 Screenshot 2021-09-14 at 12 17 24 Screenshot 2021-09-14 at 12 17 45 Screenshot 2021-09-14 at 12 18 00 Screenshot 2021-09-14 at 12 18 21 Screenshot 2021-09-14 at 12 18 39

Thank you very much for your help.

JFO

aglorias commented 3 years ago

Hello, I am having exactly the same issue. Running with the shiny app in a Mac. The data is validated and so are all other steps. I also get the "Project is ready for simulation" message, but then I try to click the "simulate" button and the orange message "Project is not read. "Check settings above" shows up.

Please let me know if you figure out how to make it run. Thanks Andrea

Linkr1991 commented 3 years ago

Yes, same issue here! I am running it on windows 10, and tried both the shiny app and the .batt app. Ran into the same problem; it tells me that the project is ready for simulation, and then to check the settings above (all of which are validated). Please let me know if you figure out how to make it work!

Linkr1991 commented 3 years ago

Other thing I noticed; when i save the project (without having been able to run the simulations) it only saves the .snp file is in the zip folder (similarly to jferrerobiol I think)

kchapin1 commented 3 years ago

I'm also having this issue. Thanks for looking into it.

jferrerobiol commented 3 years ago

Hi @gdurif, Any news on this issue? Do you think you will be able to solve the issue in the following days? Otherwise, is there a previous version that would not result in this issue that we could use in the meantime? Thank you very much for your help and apologise for the inconvenience. Really looking forward to using diyABC-RF!

kchapin1 commented 3 years ago

Is this issue still being investigated? Just wanted to get a sense of a timeline - thanks.

gdurif commented 3 years ago

Hi @jferrerobiol @kchapin1 Sorry for the late answer, I am a bit overwhelmed at work at the moment. I will look into it at the end of the week. In the mean time, you could try the previous release (but you may encounter some other issues that the current release was supposed to fix). Best

kchapin1 commented 3 years ago

Thanks for letting me know - excited to start using it.

gdurif commented 3 years ago

Hi, I am really sorry, I am totally overwhelmed by work at the moment. I am still working on this problem. I will give you an update (and hopefully a fix) ASAP.

kchapin1 commented 3 years ago

Thanks for all your efforts!

jferrerobiol commented 3 years ago

Thank you very much @gdurif! FYI, using the previous version as you proposed is working well for me at the moment.

gdurif commented 2 years ago

Hi, I finally found the problem, new release build is now in progress, see issue #116 for a summary about this matter.

gdurif commented 2 years ago

The release is out: v1.1.1-beta

gdurif commented 2 years ago

I am closing this issue. Do not hesitate to open a new one if you encounter any trouble.