dj-wasabi / ansible-telegraf

Installing and configuring Telegraf via Ansible for RedHat/Debian/Ubuntu/Windows/Suse.
MIT License
134 stars 116 forks source link

MacOS support #123

Closed carlba closed 4 years ago

carlba commented 4 years ago

Description of PR Provides MacOS support for the role. The brew service system works a bit different than most other linux/bsd service system in that it is only meant to be run as your local user account. I looked into creating a telegraf user and running the service as that but that doesn't seem inline with brew service best practices. On MacOs it is therefore required to specify a telegraf_mac_user which should be your main user account.

I also added role_name to the role meta since this is nowadays required to get the role to present correctly on Ansible Galaxy.

Type of change Feature Pull Request

dj-wasabi commented 4 years ago

Hi @carlba

Can you update the documentation about the user part so other people can benefit from it as well?

Thanks! Werner

carlba commented 4 years ago

Is this text sufficient?

dj-wasabi commented 4 years ago

@carlba Fine by me! Thanks! 👍