search

djanatyn / ssbm-nix

Nix expressions for Super Smash Bros. Melee players.
31 stars 17 forks source link

slippy-netplay does not have xdg-open #19

Closed floyza closed 2 years ago

floyza commented 2 years ago

It appears that slippy-netplay gets its xdg-open from the user environment. Without xdg_utils in my environment I get sh: line 1: xdg-open: command not found.

floyza commented 2 years ago

The initial login requires xdg-open, but I'm not sure if anything else does.

djanatyn commented 2 years ago

I just added xdg_utils to dependencies in slippi/default.nix here:

I'm building a new version to test.

sh: line 1: xdg-open: command not found

I usually have xdg-open in my environment, so I haven't seen this - I'll try to reproduce.

floyza commented 2 years ago

Yeah, you already have xdg_utils in buildInputs, it looks like.

djanatyn commented 2 years ago

Oh sorry, didn't understand at first (and didn't notice we were already using it to build).

Hmm, can we modify our derivation to provide the xdg_utils package from buildInputs whenever we're running slippi-netplay? Not sure what the appropriate convention would be here, reading some docs.

In the meantime, thanks for logging this issue!