#336 bugfix from link_menu_item to modal_menu_item: discard changes link

[svandeneertwegh]

Description

The 'discard changes' link in the versioning menu item (toolbar) is with this PR changed from add_link_item to add_modal_item.

• [v ] I have opened this pull request against master
• [x] I have added or modified the tests when changing logic
• [x] I have followed the conventional commits guidelines to add meaningful information into the changelog
• [x] I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dda7f5d) 90.86% compared to head (a0aafc7) 90.86%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #360 +/- ## ======================================= Coverage 90.86% 90.86% ======================================= Files 72 72 Lines 2530 2530 Branches 356 356 ======================================= Hits 2299 2299 Misses 170 170 Partials 61 61 ``` | [Files](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/360?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms) | Coverage Δ | | |---|---|---| | [djangocms\_versioning/cms\_toolbars.py](https://app.codecov.io/gh/django-cms/djangocms-versioning/pull/360?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-cms#diff-ZGphbmdvY21zX3ZlcnNpb25pbmcvY21zX3Rvb2xiYXJzLnB5) | `96.90% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[fsbraun]

@svandeneertwegh I have two observations:

• Upon confirming to discard changes, the modal does not close. Instead, the version list of the object is shown in the modal. I think the modal would need to close, and the page should probably redirect to the preview of the published version.
• It seems to me that the draft version actually is not discarded. I am not sure why. But it appears to stay in the version list shown in the modal.