search

django-fluent / django-fluent-comments

A modern, ajax-based appearance for django comments
https://django-fluent.org/
Apache License 2.0
182 stars 90 forks source link

fixes for Django 2.0 + Travis/Tox testing #105

Closed PetrDlouhy closed 6 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #105 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files          15       15           
  Lines         528      528           
=======================================
  Hits          449      449           
  Misses         79       79
Impacted Files Coverage Δ
fluent_comments/views.py 84.7% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43d4286...e763a18. Read the comment docs.

PetrDlouhy commented 6 years ago

@vdboor Django 2.0 is released now. I have updated the test to user plain 2.0 versions. And resolved some of your suggestions. Please answer at the remaining comments.

PetrDlouhy commented 6 years ago

@vdboor Could you please either answer my comments or pull this? Many thanks.

vdboor commented 6 years ago

I've fixed the is_authenticated check in b14a59ecf8593f8ee46f7286e8efd6bb96096348