Need to add "timeout" param into the get or post function

[BruceDone]

Hi djm: Since scrapyd server may be down , so while you using this scrapyd api , you may be block by the http error or other error, need to add the timeout param to handle this situation.

[tlinhart]

I would appreciate this as well. I might prepare PR which would basically:

• add new ScrapydAPI constructor parameter called timeout (same type as requests.request expects) storing it in instance attribute timeout
• use this attribute in every client's GET/POST request inside wrapper.py

What do you think?

[djm]

@tlinhart It's been a while but yes, that sounds good. I would accept a PR with that interface.

[tlinhart]

Thanks @djm for merging!

[djm]

No worries, thanks for proposing and enacting it!

I'll do the PyPI release this evening and update this thread.

[djm]

That's out now, v2.1.0.

Thanks again :)

[tlinhart]

Thank you too, @djm . Just wanted to ask how documentation gets updated. Changes are not reflected there.

[djm]

@tlinhart Thanks for the reminder. I've fixed that + converted the base docs to Markdown as PyPI Warehouse finally supports it 🎉.