search

djm / remark-shortcodes

A custom Markdown syntax parser for remark that adds support for shortcodes.
MIT License
45 stars 7 forks source link

Support equal signs inside attribute values #1

Closed ChristianMurphy closed 6 years ago

ChristianMurphy commented 6 years ago

Allows for attributes to have values that include quotes, for example urls that include search parameters.

djm commented 6 years ago

Thanks Christian, this looks great!

I'm a bit busy this eve but I'll look at getting an npm release out tomorrow.

codecov-io commented 6 years ago

Codecov Report

Merging #1 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files           1        1           
  Lines          42       42           
=======================================
  Hits           40       40           
  Misses          2        2
Impacted Files Coverage Δ
index.js 95.23% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5dbec3f...33f5c03. Read the comment docs.

djm commented 6 years ago

@ChristianMurphy I forgot I automated it with Travis. v0.1.5 is on its way out.

Thanks again :)

ChristianMurphy commented 6 years ago

It looks like the npm release got stuck at

You cannot publish over the previously published versions: 0.1.4. : remark-shortcodes

https://travis-ci.org/djm/remark-shortcodes/jobs/370783888#L553

djm commented 6 years ago

Oops, forgot to bump the package version. Succeeded this time :)

ChristianMurphy commented 6 years ago

Thanks @djm! :bow: