search

djoos-cookbooks / newrelic

Development repository for the newrelic cookbook
https://supermarket.chef.io/cookbooks/newrelic
MIT License
143 stars 247 forks source link

Add Distributed Tracing support for the .NET Agent #380

Closed scrthq closed 4 years ago

scrthq commented 5 years ago

Reference issue #379

The existing cookbook does not support Distributed Tracing (last update to it was before Distributed Tracing support was rolled out by New Relic). This will add that support to the dotnet agent but updating the newrelic.config.erb template and the agent_dotnet.rb custom attribute. Default setting is false to prevent impact to anyone currently using the cookbook as well as to match New Relic's default setting for new .NET APM Agent installs.

jcruzfrontline commented 4 years ago

Hey @djoos , could you take a look at this and if this looks good, approve and merge? We are looking to institute this feature and this is our only blocker.

djoos commented 4 years ago

Thanks for the contribution @scrthq! (and for the nudge @jcruzfrontline ;-) )

jcruzfrontline commented 4 years ago

Thank you so much!!!

Get Outlook for iOShttps://aka.ms/o0ukef

From: David Joos notifications@github.com Sent: Tuesday, September 24, 2019 4:46:31 AM To: djoos-cookbooks/newrelic newrelic@noreply.github.com Cc: Josh Cruz jcruz@frontlineed.com; Mention mention@noreply.github.com Subject: Re: [djoos-cookbooks/newrelic] Add Distributed Tracing support for the .NET Agent (#380)

Thanks for the contribution @scrthqhttps://github.com/scrthq! (and for the nudge @jcruzfrontlinehttps://github.com/jcruzfrontline ;-) )

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/djoos-cookbooks/newrelic/pull/380?email_source=notifications&email_token=AG7N3URVKB3DVJVTCS4R5S3QLHHWPA5CNFSM4H2UO2KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7NTD2Q#issuecomment-534458858, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG7N3UWE464K5BGSCEGBZFLQLHHWPANCNFSM4H2UO2KA.

This email may contain information that is confidential or attorney-client privileged and may constitute inside information. The contents of this email are intended only for the recipient(s) listed above. If you are not the intended recipient, you are directed not to read, disclose, distribute or otherwise use this transmission. If you have received this email in error, please notify the sender immediately and delete the transmission. Delivery of this message is not intended to waive any applicable privileges.