search

dkim0419 / SoundRecorder

A simple sound recording app implementing Material Design
GNU General Public License v3.0
1.49k stars 808 forks source link

Create strings.xml for South Korea #111

Closed onestone9900 closed 5 years ago

onestone9900 commented 5 years ago

Hi, I created string.xml for South Korea I confirm PR history and test my smart phone before pull requset. but if exist any wrong form, comment please~ Thank you!! :)

naXa777 commented 5 years ago

If you don't mind, I'd like to import your translation in my fork of this repository. I've already created a pull request here https://github.com/naXa777/SoundRecorder/pull/41 (the app is in alpha testing; not released yet)

onestone9900 commented 5 years ago

If you don't mind, I'd like to import your translation in my fork of this repository. I've already created a pull request here naXa777#41 (the app is in alpha testing; not released yet)

my pleasure :) !!!

naXa777 commented 5 years ago

@sowen2819 I see that you added commits unrelated to this PR. Please, keep it clean: one PR - one change. It may contain multiple commits, but they should be related to the PR topic ("South Korean translation" in this case).

You probably did it unintentionally, because you do everything in master branch. In order to prevent such kind of errors in future, please work in a new branch, then create a pull request from this branch. Then go back to master and create a new branch if you want to implement anything else. Also, if you want you can create PR to multiple repositories and/or merge the branch into your master branch.

I hope my suggestions will help you to keep your git history and PRs clean.

onestone9900 commented 5 years ago

@sowen2819 I see that you added commits unrelated to this PR. Please, keep it clean: one PR - one change. It may contain multiple commits, but they should be related to the PR topic ("South Korean translation" in this case).

You probably did it unintentionally, because you do everything in master branch. In order to prevent such kind of errors in future, please work in a new branch, then create a pull request from this branch. Then go back to master and create a new branch if you want to implement anything else. Also, if you want you can create PR to multiple repositories and/or merge the branch into your master branch.

I hope my suggestions will help you to keep your git history and PRs clean.

oh.....my mistake. So I reset my repository. I thought sending PR only my previous commits( Create strings.xml for South Korea ). but continues to add commit in PR.... I'll be careful

thank you feedback. I try it!