search

dkoudlo / TwitterClient

0 stars 0 forks source link

Please Review Twitter Client App #1

Open dkoudlo opened 10 years ago

dkoudlo commented 10 years ago

@nesquena could you please review my code?

Trying to use a fragment to add new tweet to the top of the list. There is no refresh here yet.

nesquena commented 10 years ago

You don't need to use a fragment. Just use adapter.insert to insert the tweet object. All you need to do is take the response from the compose (onsuccess), parse the tweet and return it as a result to the activity. On the activity result, insert the tweet. Does that help?

nesquena commented 10 years ago

You also don't have endless pagination working. Can you please ping me back here when you have the required user stories?

dkoudlo commented 10 years ago

Yes I totally will.

Danil Koudlo Software and Web Cell: (248) 635-4554 Skype: danil.koudlo LinkedIn: www.linkedin.com/in/danilkoudlo

On Wed, Feb 5, 2014 at 12:34 AM, Nathan Esquenazi notifications@github.comwrote:

You also don't have endless pagination working. Can you please ping me back here when you have the required user stories?

Reply to this email directly or view it on GitHubhttps://github.com/dkoudlo/TwitterClient/issues/1#issuecomment-34146477 .

dkoudlo commented 10 years ago

Hi @nesquena I completed all of the required stories and started on some optional ones like adding the counter for the number of characters. Because of the changes I had to make to the model, it got me closer to the persistence as well. Dont have any energy left in me to do the persistence tonight though. :/ Please let me know what you think.

nesquena commented 10 years ago

:+1: nice work overall. A few notes after checking out the code:

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together. We are close to a turning point in the course where you should be hitting a "critical mass" for your Android knowledge.

Dont have any energy left in me to do the persistence tonight though.

That's fine, the next project is extending the twitter client so you will have an opportunity to add it this coming week.