leimaohui
commented
3 years ago Hi, Paul
Thank you for your comment. Yes, that’s a good idea, I’ll try to fix this issue.
Best regards Lei
From: Paul Eggleton notifications@github.com Sent: Friday, October 23, 2020 5:11 AM To: dl9pf/meta-spdxscanner meta-spdxscanner@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [dl9pf/meta-spdxscanner] Integrate do_spdx nopackages integration into spdx-common class (#23)
Given that overlaying classes across layers is somewhat unreliable, instead of providing a custom version of the nopackages class in this layer you could add some anonymous python to the spdx-common class which conditionally adds the do_spdx task (replacing the non-conditional addtask directive) or deletes the task based upon whether nopackages is inherited. (Just a thought.)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/dl9pf/meta-spdxscanner/issues/23, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC3HRZOBNJ2LNIFFLTBGDPDSMCNV5ANCNFSM4S3XMF2Q. [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/dl9pf/meta-spdxscanner/issues/23", "url": "https://github.com/dl9pf/meta-spdxscanner/issues/23", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]
Given that overlaying classes across layers is somewhat unreliable, instead of providing a custom version of the nopackages class in this layer you could add some anonymous python to the spdx-common class which conditionally adds the do_spdx task (replacing the non-conditional addtask directive) or deletes the task based upon whether nopackages is inherited. (Just a thought.)