dlamotte / django-tagging

Automatically exported from code.google.com/p/django-tagging
Other
0 stars 0 forks source link

TagAdminForm.clean_name leaves trailing comma "," in multi-word tag name #248

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
The issue:

creating a new multi-word tag in /admin/tagging/tag/ using the model admin 
raises an error if there are spaces in the tag. If you append a "," to the end 
of the multiword tag to indicate that it should be treated as a single tag 
(with spaces), that comma is treated literally and saved to the database.

if we take for granted that the admin user is potentially silly enough to 
*intend* to insert two tags in the Tag create view, and the validation error is 
thrown, subsequently he is compelled to append a comma to his input to indicate 
that this a single tag. However, the system as it stands accepts that comma as 
literal input and it is committed to the database!

Second problem: if we expect a multi-word tag to be indicated by a trailing "," 
in the admin create form, then we also need to render the form such that the 
name field has a trailing "," where appropriate. 

I've attached a patch that hopefully solves both problems by treating Tag model 
creation via the Tag admin create view as literal input and as a single tag.

Original issue reported on code.google.com by sam.vev...@gmail.com on 2 Jul 2010 at 7:30

Attachments: