dlang-community / setup-dlang

Github action for dlang compiler setup
MIT License
46 stars 14 forks source link

`dmd-2.098.0-beta.2` doesn't work (wrong URL) #50

Closed kinke closed 5 months ago

kinke commented 3 years ago

From https://github.com/atilaneves/mirror/pull/28/checks?check_run_id=3742108306:

Enabling dmd-2.098.0-beta.2
Downloading http://downloads.dlang.org/releases/2.x/2.098.0-beta.2/dmd.2.098.0-beta.2.linux.tar.xz
HTTPError: Unexpected HTTP response: 403
    at /home/runner/work/_actions/dlang-community/setup-dlang/v1.0.5/node_modules/@actions/tool-cache/lib/tool-cache.js:100:25
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/dlang-community/setup-dlang/v1.0.5/node_modules/@actions/tool-cache/lib/tool-cache.js:5:58)
    at processTicksAndRejections (internal/process/task_queues.js:93:5) {
  httpStatusCode: 403
}
kinke commented 3 years ago

Correct URL: http://downloads.dlang.org/pre-releases/2.x/2.098.0/dmd.2.098.0-beta.2.linux.tar.xz

mihails-strasuns commented 3 years ago

Currently only generic dmd-beta version is recognized (which resolves to the latest beta), anything matching /^(2\.(\d+)\.\d+)(-.+)?$/ is treated as an actual release. This is a bug, will need to enhance beta detection a bit to also recognize -beta.N suffix.