dlang / dub

Package and build management system for D
MIT License
673 stars 230 forks source link

Build fails with ldc 1.33.0 #2716

Closed ptrcnull closed 10 months ago

ptrcnull commented 10 months ago

System information

Bug Description

A lot of deprecation warnings turned into errors when trying to build latest dub stable with latest ldc:

source/dub/dependency.d:917:32: error: scope variable 'this' assigned to non-scope parameter 'oth' calling 'opEquals' [-Werror=deprecated]
  917 |                 if (m_versA == m_versB)
      |                                ^
source/dub/dependency.d:920:44: error: scope variable 'this' assigned to non-scope parameter 'a' calling 'doCmp' [-Werror=deprecated]
  920 |                 return doCmp(m_inclusiveA, m_versA, v) &&
      |                                            ^
source/dub/dependency.d:921:48: error: scope variable 'this' assigned to non-scope parameter 'b' calling 'doCmp' [-Werror=deprecated]
  921 |                         doCmp(m_inclusiveB, v, m_versB);
      |                                                ^
source/dub/dependency.d:939:40: error: scope variable 'this' assigned to non-scope parameter 'oth' calling 'opEquals' [-Werror=deprecated]
  939 |                 return this.m_versA == this.m_versB;
      |                                        ^

How to reproduce?

Expected Behavior

dub builds correctly despite the deprecation warnings and doesn't block downstream usage by enforcing every warning to be a fatal error

Logs

https://dev.alpinelinux.org/~ptrc/dub-1.34.0-r0.log

ptrcnull commented 10 months ago

nevermind, apparently gdc was being installed and picked by accident, closing in favour of #2577