Closed gedaiu closed 9 months ago
✅ PR OK, no changes in deprecations or warnings
Total deprecations: 14
Total warnings: 0
Build statistics:
statistics (-before, +after)
executable size=5331080 bin/dub
-rough build time=76s
+rough build time=75s
Under what circumstances does the bug trigger ? Can you add a test ?
Hey @Geod24, it happens with one of my weirdly configured projects. Unfortunately, I can't reproduce it with a unit test without doing some refactoring in that function.
@gedaiu : Could you share the package recipe (and perhaps selections) of the involved packages ? I might be able to write the UT for you.
Actually there is a very simple test here: https://github.com/dlang/dub/issues/2696 However I was looking at this code and there are more issues with it (namely subpackages would also trigger segv).
Submitted a more complete fix with tests in #2762 . Thanks for your PR though @gedaiu , because it led me to find other bugs!
fix #2724