search

dlmanning / gulp-sass

SASS plugin for gulp
MIT License
1.57k stars 381 forks source link

update dependencies #742

Closed mimoduo closed 5 years ago

mimoduo commented 5 years ago

Hey dlmanning,

https://github.com/dlmanning/gulp-sass/issues/741 Just going through and updating the dependencies.

Sincerely, Bryan Stoner

allan-simon commented 5 years ago

awesome, it will permit us not to have to recompile node-sass everytime :)

allan-simon commented 5 years ago

strange enough the build is failing :/

xzyfer commented 5 years ago

This is far too aggressive of a change.

It breaks backwards compatibility because some dependencies that were bumped have dropped Node < 6.

The bump of eslint has unnecessarily introduce new lint errors.

xzyfer commented 5 years ago

awesome, it will permit us not to have to recompile node-sass everytime :)

You should never have to do to this. Just make sure you're running the latest node-sass. See npm ls node-sass.

allan-simon commented 5 years ago

It breaks backwards compatibility because some dependencies that were bumped have dropped Node < 6.

Isn't node < 6 node more officially maintained ? (I think even node 8 is in maintenance mode ?)

allan-simon commented 5 years ago

You should never have to do to this. Just make sure you're running the latest node-sass.

it's doing so because it does not find the good pre-built binary on github releases (the version of node-sass used by gulp-sass has no node-11 pre-built if I'm not mistaken )

xzyfer commented 5 years ago

gulp-sass will use the latest node-sass@4.x available at the time of install because of the ^ in package.json

On Fri., 16 Aug. 2019, 2:32 am Allan Simon, notifications@github.com wrote:

You should never have to do to this. Just make sure you're running the latest node-sass.

it's doing so because it does not find the good pre-built binary on github releases (the version of node-sass used by gulp-sass has no node-11 pre-built if I'm not mistaken )

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/dlmanning/gulp-sass/pull/742?email_source=notifications&email_token=AAENSWEH2CEO3UMLN4PIQETQEWAI3A5CNFSM4ILCCZT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4MJ5VQ#issuecomment-521707222, or mute the thread https://github.com/notifications/unsubscribe-auth/AAENSWHCY253DKR7IVJW2JLQEWAI3ANCNFSM4ILCCZTQ .