dlr-gtlab / intelligraph-module

A Node-based Workflow Engine for GTlab
1 stars 0 forks source link

Loading project causes crash if unknown nodes are part of a graph #113

Closed rainman110 closed 2 months ago

rainman110 commented 2 months ago

In GitLab by @jensschmeink on Sep 10, 2024, 11:54

Summary

I have a graph with nodes from the ACDC module. If the module is not part of the setup and you open the project GTlab crahses.

Which software is probably the cause of the error?

The debugger indicates that there is an assert in the function Graph::restoreConnection(Connection* connection) which leads to the crash.
Of cause the assert it self is not the problem but the case of nodes which are not found.

The case of unknown nodes seems not to be considered in the function.

What is the current bug behavior?

A crash.

What is the expected correct behavior?

A warning that the connection could not be restored

Steps to reproduce

Build a graph with module specific nodes and then remove the module from your setup. Then open the project.

Relevant logs and/or screenshots

(Paste any relevant logs - use code blocks (```) to format console output, logs, and code, as it's very hard to read otherwise.)

GTlab environment

(Add details to your GTlab environment. If the bug relates to a module, please also add the module and its version.)

rainman110 commented 2 months ago

In GitLab by @jensschmeink on Sep 10, 2024, 11:54

created branch 113-problem-with-model-crash-if-unknown-nodes-are-part-of-the-model to address this issue

rainman110 commented 2 months ago

In GitLab by @mariusalexander on Sep 10, 2024, 14:03

mentioned in commit 615d3a366c6767bbe83322836667c23b6a130923