Resolve "Loading project causes crash if unknown nodes are part of a graph" - [merged] #185

Closed rainman110 closed 2 months ago

In GitLab by @jensschmeink on Sep 10, 2024, 11:54

Merges 113-problem-with-model-crash-if-unknown-nodes-are-part-of-the-model -> main

Closes #113

In GitLab by @jensschmeink on Sep 10, 2024, 11:55

added 1 commit

e72d639d - basic test to skip restore of connection

In GitLab by @jensschmeink on Sep 10, 2024, 11:56

@mariusalexander I added a small check. I know this is not the sufficient solution but is a first indicator to find the specific problem.

In GitLab by @jensschmeink on Sep 10, 2024, 12:02

Commented on src/intelli/graph.cpp line 816

    auto conData = m_local.find(connection->inNodeId());
    auto conDataOut = m_local.find(connection->outNodeId());

    if (conData == m_local.end() || conDataOut == m_local.end())
    {
        gtWarning() << tr("Cannot restore connection") << conId;
        return;
    }

    assert(conData != m_local.end());

In GitLab by @jensschmeink on Sep 10, 2024, 12:02

resolved all threads

In GitLab by @jensschmeink on Sep 10, 2024, 12:02

added 1 commit

27d99b47 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

In GitLab by @mariusalexander on Sep 10, 2024, 13:50

I think there is currently no way around such a check. I'll update the solution as there is an alternative method that we can use if we are unsure whether a node in the connection model exists. Maybe once we figured out how to implement a dummy node #107. Good catch!

In GitLab by @mariusalexander on Sep 10, 2024, 13:52

Commented on src/intelli/graph.cpp line 816

changed this line in version 3 of the diff

In GitLab by @mariusalexander on Sep 10, 2024, 13:52

added 1 commit

1ba16b2b - avoid using iterators to in- and output node directly

Compare with previous version

In GitLab by @mariusalexander on Sep 10, 2024, 13:52

marked this merge request as ready

In GitLab by @mariusalexander on Sep 10, 2024, 13:52

requested review from @jensschmeink

In GitLab by @mariusalexander on Sep 10, 2024, 14:03

mentioned in commit 615d3a366c6767bbe83322836667c23b6a130923

dlr-gtlab / intelligraph-module

Resolve "Loading project causes crash if unknown nodes are part of a graph" - [merged] #185