Update licensing - [merged] #191

Closed rainman110 closed 2 months ago

In GitLab by @mariusalexander on Sep 16, 2024, 09:29

_Merges updatelincensing -> main

Updated licensing information in source files

Closes #81

In GitLab by @mariusalexander on Sep 16, 2024, 09:50

added 1 commit

15d78ac1 - initial commit to add license information

Compare with previous version

added 2 commits

b53f6123 - Started adding license headers
3f3f06dd - Added license check and cppcheck jobs

Compare with previous version

added 1 commit

0b4e0dea - Added missing license

Compare with previous version

In GitLab by @mariusalexander on Sep 20, 2024, 09:33

added 2 commits

98eec707 - added license information to source files
bd30ab51 - added missing license information

Compare with previous version

In GitLab by @mariusalexander on Sep 20, 2024, 09:33

@rainman110

I think I have adapted all headers and added license info from QtNodes to the header of the file if applicable (mostly graphics objects and painter and geometry). I also marked few snippets of code that are mostly copied 1:1 from QtNodes (may have renamed variables or intended the snippets differently).

However, I have noticed that I have also copied some code snippets from GTlab (Core) either becuase they are not exported (see intelli::ObjectLinkPropertyItem) or because I have altered them in a slight way (see module.cpp, there are a few lines of codes that were copied and adapted from GTlab Core which were marked with "stolen from ..." :joy:) What should we do about these?

I have also added a "license information" to the module in the metaInformation() function, maybe you could check the license text there as well?

In GitLab by @mariusalexander on Sep 20, 2024, 09:36

Commented on 8ca3a0ef8234b63cbc14237be7475be38b4f8179

What is the purpose of this file?

It is used for CC0 licensed parts. CC0 basically means, its a gift from us to all.

We use it for trivial files. e.g. a doxygen config

In GitLab by @mariusalexander on Sep 20, 2024, 09:37

Commented on 8ca3a0ef8234b63cbc14237be7475be38b4f8179

Ah I see!

In GitLab by @mariusalexander on Sep 20, 2024, 09:38

Commented on LICENSES/BSD-3-Clause.txt line 1

Shouldn't this be edited as well? Maybe like this?

Copyright (c) 2024 Marius Bröcker

No, please see here: https://reuse.software/faq/#edit-license and https://reuse.software/faq/#license-templates

It is explicitly left blank.

Otherwise, someone using our license need to ship it separately as we did with the bsd license from qtnodes.

In GitLab by @mariusalexander on Sep 20, 2024, 09:48

resolved all threads

However, I have noticed that I have also copied some code snippets from GTlab (Core) either becuase they are not exported (see intelli::ObjectLinkPropertyItem) or because I have altered them in a slight way (see module.cpp, there are a few lines of codes that were copied and adapted from GTlab Core which were marked with "stolen from ..." :joy:) What should we do about these?

As long as these code pieces are trivial / non-critical, i don't see problems. You don't need to mark them as MPL-2.0, we have the copyright and can decide it. If it is more code, then you could extract the "Core" code pieces, put them in one file and license it under MPL-2.0.

I think it is okay to just ref to BSD-3-Clause. Otherwise, we would need to list all licenses here.

In GitLab by @mariusalexander on Sep 20, 2024, 10:35

resolved all threads

In GitLab by @mariusalexander on Sep 20, 2024, 10:54

Commented on src/intelli/module.cpp line 112

changed this line in version 5 of the diff

In GitLab by @mariusalexander on Sep 20, 2024, 10:54

added 1 commit