search

dlr-gtlab / intelligraph-module

A Node-based Workflow Engine for GTlab
1 stars 0 forks source link

FindDirectChildNode: more specific search based on child object name added #216

Closed jensschmeink closed 1 week ago

jensschmeink commented 2 weeks ago

The current findDirect child node has a problem to find a specific child if there is more than one object of the same class. Only the first one can be selected. The new implementation adds a second EditLine to select an object name to make the search more specific (if needed).

The whole graphical part is now defined in a separate class.

Closes #100

mariusalexander commented 2 weeks ago

@jensschmeink I have checked out your code currently and adapted some minor coding style/indentation things things. I also fixed a bug where the node would not output null-data if no matching child was found. I also trigger an "evaluation failure" if no valid object was found. This results in the node being marked with a red dot.

One thing is unclear to me: Why is the class edit hidden in non-dev mode? I thought the node could be used to search by class and then filter by name. We could think about implementing it in such a way that if the class edit is empty the name is used, if the the class name is not empty, we use it in conjunction with the object name (if its not empty)

jensschmeink commented 2 weeks ago

@jensschmeink I have checked out your code currently and adapted some minor coding style/indentation things things. I also fixed a bug where the node would not output null-data if no matching child was found. I also trigger an "evaluation failure" if no valid object was found. This results in the node being marked with a red dot.

One thing is unclear to me: Why is the class edit hidden in non-dev mode? I thought the node could be used to search by class and then filter by name. We could think about implementing it in such a way that if the class edit is empty the name is used, if the the class name is not empty, we use it in conjunction with the object name (if its not empty)

The name is used for the search even if the class is not specified. AS the "normal user" does not know any class names this should be the default use case in the non-dev mode. For experts the classname can be accessable as a further hint