bug fixes, play from query parameter, smaller recording files (fixes #6)

ngokevin commented 7 years ago

Tested avatar recording on Firefox Nightly:

Changes:

Allow specifying recording from query parameter. This required some refactoring:
- Let avatar-replayer decide where to source its recording data (localStorage, data.src, queryParam).
- avatar-recorder only calls avatar-replayer.startReplaying(data) manually after a recording.
- On initialization with autoplay, avatar-recorder will set avatar-replayer without anything else, letting avatar-replayer handle the replaying.
Update tests and docs.

Bug Fixes:

Fixed buttonchanged event recording since evt.detail.state was a non-serializable object.
Fixed avatar recording. Before we were mapping controller trigger to toggle recording for the strokes/Pac Man use case. I temporarily commented it out.
Fixed replay on empty data (i.e., one of my controllers not tracking).

Style:

More renames from play -> replay.
Simplify default recording file name a bit (remove timestamp, lowercase) for easier management, OSes will append a number for duplicated file names.

dmarcos commented 7 years ago

The PR does not run to me on examples\play.html. I get a console error from a-entity.emit. Probably caused by the introduced constants

ngokevin commented 7 years ago

OK, I backed out the constants stuff. Let me see if I can get a link to a good recording.

ngokevin commented 7 years ago

ain

ngokevin commented 7 years ago

recording

dmarcos / aframe-motion-capture-components