Added IE8 support in coffeescript file

dmauro / Keypress

A keyboard input capturing utility in which any key can be a modifier key.

http://dmauro.github.io/Keypress/

Apache License 2.0

3.18k stars 313 forks source link

Added IE8 support in coffeescript file #4

Closed richard77 closed 11 years ago

richard77 commented 11 years ago

Although not intensively tested it seems to be working in IE8. In short:

Added Array.prototype.filter function (as IE8 lacks it)
use window.event when passed event is empty in onButtonDown and onButtonUp
use event.returnValue = false in case event.preventDefault() is not present.

dmauro commented 11 years ago

It looks like you shouldn't need the lines that read "keyCode = if (window.event) then window.event.keyCode else e.keyCode" because you're already doing "e = e or window.event" when first handling the events. Unless I'm missing something.

richard77 commented 11 years ago

you're right, this was an earlier attempt to fix things. it can be removed/ignored

2012/12/19 David Mauro notifications@github.com

It looks like you shouldn't need the lines that read "keyCode = if (window.event) then window.event.keyCode else e.keyCode" because you're already doing "e = e or window.event" when first handling the events. Unless I'm missing something.

— Reply to this email directly or view it on GitHubhttps://github.com/dmauro/Keypress/pull/4#issuecomment-11546484.

dmauro commented 11 years ago

Awesome, nice work!

dmauro commented 11 years ago

I made some minor changes and recompiled the minified JS.