search

dmauro / Keypress

A keyboard input capturing utility in which any key can be a modifier key.
http://dmauro.github.io/Keypress/
Apache License 2.0
3.18k stars 313 forks source link

Support for F# buttons #54

Closed drochag closed 9 years ago

drochag commented 9 years ago

Maybe function buttons could be handled

dmauro commented 9 years ago

I'll take another look, but I'm probably not going to merge this just because I think supporting F# buttons is going to be infeasible across many browsers.

drochag commented 9 years ago

Search across some resources, found this among a few others claiming the same keycodes stands for Mozilla, IE, Opera and pseudo ASCII codes, which means, I think F# keycodes are crossbrowser. Noticed it was added as issue a few days ago #53

dmauro commented 9 years ago

Actually, I'm not against going ahead and merging this in, but I'm going to leave it as an undocumented and unsupported feature. Then maybe I can phase it in completely if it seems doable in all browsers. Do you mind pointing this PR at develop instead of master (sorry I had master set up as my default branch, my fault).

drochag commented 9 years ago

Didn't find where to change it, should I make a new one?

dmauro commented 9 years ago

Yeah, I think the only way is to delete this PR and open a new one. If you ever find a way to change it, please let me know :)