search

dmihal / l2-fees

l2-fees.vercel.app
31 stars 16 forks source link

Fix NaN total L1 fees #9

Open hesom opened 2 years ago

hesom commented 2 years ago

I'm getting NaN value in the "Total" row in L1 Security Costs tab. The main reason is the NaN value inside the result of the data prop of L1List. I fixed this by simply adding 0 to the total if the result is invalid.

I think the reason for the NaN is an error in the API call that is supposed to get the DeversiFi fees. This causes the results of the children of StarkNet in the bundleItems function to not be added correctly. I fixed this similarly by just adding 0 if the current result is invalid.

firefox_Z2cGFQYFIu firefox_6GUFhJZ5K0

vercel[bot] commented 2 years ago

@hesom is attempting to deploy a commit to the ETH Burned Team on Vercel.

A member of the Team first needs to authorize it.