search

dmlc / dmlc-core

A common bricks library for building scalable and portable distributed machine learning.
Apache License 2.0
864 stars 519 forks source link

Get rid of std::iterator which is deprecated in C++17 #678

Closed rongou closed 1 year ago

rongou commented 1 year ago

XGBoost recently moved to C++17 (https://github.com/dmlc/xgboost/pull/8853) which now shows a deprecation warning for calling std::iterator. See https://www.fluentcpp.com/2018/05/08/std-iterator-deprecated/.

rongou commented 1 year ago

@hcho3

hcho3 commented 1 year ago

Thanks!