🐛 Bug: Upgrading Node to verison 18 broke builds

dmnd / dedent

⬅️ ES6 string tag that strips indentation from multi-line strings.

MIT License

931 stars 36 forks source link

🐛 Bug: Upgrading Node to verison 18 broke builds #92

Closed dontforgit closed 7 months ago

dontforgit commented 7 months ago

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Expected

A major node version dependency should not be upgraded in a bug fix.

Actual

NPM is showing the latest version is 1.5.2, which requires Node 18. This is breaking our application since Jest 29.5.0 has this somewhere in the dependency tree only supporting Node 16.

Additional Info

It looks like that tag was removed from GitHub. A new tag that reverts functionality back to 1.5.1 should be tagged as 1.5.3.

sconzof commented 7 months ago

+1 It would be greatly appreciated if you could please create a 1.5.3 release that restores version 1.5.1. Thank you!

nikolareljin commented 7 months ago

+1 Can you please create the tag 1.5.3 for https://www.npmjs.com/package/dedent since the 1.5.2 in NPMjs breaks the installation of other dependent packages?

JoshuaKGoldberg commented 7 months ago

Sorry about that folks! I published 1.5.3 now that removes the added engines field altogether. Thanks for the quick bug reports!

github-actions[bot] commented 7 months ago

:tada: This is included in version v1.5.3 :tada:

The release is available on:

Cheers! 📦🚀

dontforgit commented 7 months ago

Sorry about that folks! I published 1.5.3 now that removes the added engines field altogether. Thanks for the quick bug reports!

Thank you for the quick fix @JoshuaKGoldberg !!