Update vendor list

[PhilippHaefele]

Short description of change

Updated vendors from a vid file that was kindly provided to me from ODVA.

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [x] I have read the docs/CONTRIBUTING.md document.
• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read tests/README.md.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed. => Sorry i do not have a micro 800, but changes shouldn't break any test

What is the change?

I wrote a small python script to read the ODVA file and output in a predefined format, so i can update vendors in different tools. To preserve obsolete vendors, i issue a list of them separately.

Some company names have special UTF-8 characters like ü, ä, ç, ã and ）/ U+FF09 and as this lib does have a python 2 support i replace them with matching replacement values (e.g. ü => ue).

There were some Reserved entries in the list and as they do not have any informational value i removed them.

What does it fix/add?

Updated vendor list

Test Configuration

as mentioned above i couldn't do a test as i do not have a micro 800

[TheFern2]

I guess it doesn't matter much for the vendors list because it probably hasn't changed in either repo but just fyi, this fork is from pylogix2 (Daniel) not pylogix. Daniel has a rogue fork, we tried working with him on a PR and he decided to ignore all communication.

So in the future if you want to make more PRs please fork this repo or add this repo as upstream to keep up with the latest changes.

[dmroeder]

I guess it doesn't matter much for the vendors list because it probably hasn't changed in either repo but just fyi, this fork is from pylogix2 (Daniel) not pylogix. Daniel has a rogue fork, we tried working with him on a PR and he decided to ignore all communication.

So in the future if you want to make more PRs please fork this repo or add this repo as upstream to keep up with the latest changes.

Oof, good eye. The gift that keeps on giving.

[TheFern2]

Yeah, it sucks that you can't control which forks can submit PRs or maybe you can I dunno. Is clearly he wanted to go his own route so he shouldn't made a fork. Because PRs come to the original repo.

[dmroeder]

It appears that @PhilippHaefele forked pylogix2, then brought it up to be closer in line with pylogix.

[TheFern2]

It appears that @PhilippHaefele forked pylogix2, then brought it up to be closer in line with pylogix.

yeah I saw version was the same in init file. As long as there are no conflicts is fine. PR is good to go though.

[PhilippHaefele]

Yep i locally have the right repo checked out, branched from the right master and everything seems to line up ok in my branch as @TheFern2 mentioned.

The problem is, that i cannot create a fork of pylogix and pylogix2, as GitHub forbids to fork a repo twice (pylogix & pylogix2 are fork-linked and therefore are the "same" base repo for GitHub).

I'm literally just doing the same change for pylogix2 and it just happened that i forked pylogix2 first.

Sorry should habe mentioned that.

[dmroeder]

@PhilippHaefele, Line 1394 is still a problem.

[TheFern2]

That's:

>>> comp = "Automação"
>>> comp
'Automação'

Probably best to just leave it as Automacao to avoid decoding issues down the road.

[dmroeder]

That's what I did when testing it locally

[TheFern2]

yeah that line was most likely auto generated and had a unicode decoding issue, that's why I recommend to use ascii 65-122 letters.

[PhilippHaefele]

Oh sorry forgot them in my replacing logic.

Will try to change it tomorrow

[PhilippHaefele]

Just pushed a fixed version

[PhilippHaefele]

Thanks, happy to help improving this python package