Closed anton-plebanovich closed 6 years ago
Note to self: Test fails as it invokes old import method without error object.
Merging #86 into master will decrease coverage by
<.01%
. The diff coverage is56.52%
.
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 69.39% 69.39% -0.01%
==========================================
Files 16 16
Lines 1490 1503 +13
Branches 142 143 +1
==========================================
+ Hits 1034 1043 +9
- Misses 388 392 +4
Partials 68 68
Impacted Files | Coverage Δ | |
---|---|---|
AssimpKit/Code/Model/Tests/AssimpImporterTests.m | 53.73% <100%> (+0.11%) |
:arrow_up: |
AssimpKit/Code/Model/SCNScene+AssimpImport.m | 53.84% <30%> (-14.58%) |
:arrow_down: |
AssimpKit/Code/Model/AssimpImporter.m | 87.39% <40%> (+0.37%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a603ac7...cc3854c. Read the comment docs.
Code coverage issue because deprecated methods aren't using in tests and i'm not sure they should.
@anton-plebanovich
Code coverage issue because deprecated methods aren't using in tests and i'm not sure they should.
Makes sense.
Merging. Thanks a ton!
…port