search

dmwm / CRABServer

16 stars 38 forks source link

Enable install WMCore from private repository #8683

Closed novicecpp closed 2 months ago

novicecpp commented 2 months ago

Fix https://github.com/dmwm/CRABServer/issues/8582

In summary, put the conditional check into a new installWMCore.sh script. If repository specify in wmcore_requirements.txt is dmwm/WMCore, always install wmcore from PyPI packages. Otherwise, clone it and copy whole src/python to install directory.

cmsdmwmbot commented 2 months ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2157/artifact/artifacts/PullRequestReport.html

belforte commented 2 months ago

Looks very cool and quite likely my doubts only come from ignorance, so I beg you to describe things a little more. Instructions for different ways of installing could e.g. be part of the initial comments in /wmcore_requirements.txt. But let's not have the description of this PR as documentation !

cmsdmwmbot commented 2 months ago

Jenkins results:

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2164/artifact/artifacts/PullRequestReport.html

belforte commented 2 months ago

very good, thanks !

novicecpp commented 2 months ago

Thanks!