search

dmwm / DBSClient

Apache License 2.0
3 stars 8 forks source link

Fix DBSValidation checks #38

Closed vkuznet closed 2 years ago

vkuznet commented 2 years ago

@yuyiguo I made these changes when I was testing and debugging issues with migration server. They address the different JSON representation for non existing data (null vs empty list).

vkuznet commented 2 years ago

@yuyiguo please review this PR as I need it for testing new server. I keep it fully backward compatible with existing DBS Python server tests.

yuyiguo commented 2 years ago

@vkuznet First , can you merge the three commits into one? Second, the validation tests are for release testing, not for debugging a API. You put a lot of prints in the code. This will make a lot of output and defeat the purpose of the validation tests.

vkuznet commented 2 years ago

I squashed changes, but printous are useful, if you want I can hide them under self.debug. I'm trying to provide code which can be useful for both implementation and allow to identify various issues.

yuyiguo commented 2 years ago

Please hide all your print out under self.debug. This is what the self.debug for. It is very hard to find errors when release tests are full of no essential message. We only want to see error messages while for releasing. Please squash all commit into one after you are done. Thanks !

vkuznet commented 2 years ago

ok, done, please review.