[Bug] Mobile issues - Githubissues

cclypeatus commented 4 months ago

[X] The banner image isn't showing up on mobile. Might be a file size issue? map-icris.jpg is working fine at 4.21mb, but banner-snowhaven.png is at 6.29mb.
[ ] Links in Panel component in https://dndworld.github.io/after-creating-your-character/start-playing/ also won't work for me on mobile

On GitBook, all the pages have this big gap above the page title for some reason, but page opens so title is in expected position so not a big problem.

dndworld commented 2 months ago

I encountered the same bug. For me, the banner is cut in half. Not sure if there is any way to block the banner from displaying on mobile totally? Might be a band-aid solution if we can't figure out what is causing the bug.

Edit: Can confirm that Pen also experiences this bug.

cclypeatus commented 2 months ago

I've prepared two fixes for the mobile banner issue:

adjusted the banner crop, which is what is currently shown on the GitHub Page
band-aid solution of not displaying, currently commented out

My phone still has issues displaying the image file itself, so tell me if the first one looks better for you guys :thumbsup:

I also need to go back and fix what part gets cropped in - the picture keeps getting offset on my Retype preview, but I just figured out a way to fix that. Tell me if there is a particular crop you would prefer; I am going for 100% width, roughly top edge ends just above Black Shields/sea-green-ish blue and bottom edge just below graveyard.

cclypeatus commented 2 months ago

For the second issue, opened an issue in Retype for it: https://github.com/retypeapp/retype/issues/707

dndworld / dndworld.github.io

[Bug] Mobile issues #11